Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): update postee version #587

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(helm): update postee version #587

merged 1 commit into from
Jul 17, 2023

Conversation

DmitriyLewen
Copy link
Collaborator

Description

Helm uses old version of Postee.
Update it.

@DmitriyLewen DmitriyLewen marked this pull request as draft July 17, 2023 06:36
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 17, 2023 06:51
@DmitriyLewen DmitriyLewen requested a review from simar7 July 17, 2023 06:51
@DmitriyLewen
Copy link
Collaborator Author

DmitriyLewen commented Jul 17, 2023 •
edited
Loading

@simar7 can you take a look, please.

We also need to remember to update the Aqua Chart Repository after merging this PR.

@DmitriyLewen DmitriyLewen mentioned this pull request Jul 17, 2023
Merged
simar7
simar7 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simar7 simar7 merged commit adcf9a1 into main Jul 17, 2023
@simar7
Copy link
Member

simar7 commented Jul 17, 2023

@simar7 can you take a look, please.

Merged.

We also need to remember to update the Aqua Chart Repository after merging this PR.

Could you look into this?

@DmitriyLewen DmitriyLewen deleted the fix/postee-2.12.0-helm-version branch July 17, 2023 09:25
@DmitriyLewen
Copy link
Collaborator Author

DmitriyLewen commented Jul 17, 2023 •
edited
Loading

@simar7 We just need to run publish-chart action, right?

UPD:
I checked - Aqua Chart Repository still uses old version:

➜  ~ helm helm repo update
➜  ~ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "aquasecurity" chart repository
Update Complete. ⎈Happy Helming!⎈
➜  ~ helm show values aquasecurity/postee --version v2.12.0 | grep tag: -B 3
    # usernameKey: username
    # passwordKey: password
  image: aquasec/postee-ui
  tag: "2.8.4-amd64"
--
image:
  repository: aquasec/postee
  pullPolicy: Always
  tag: "2.8.4-amd64"
imageInit:
  repository: busybox
  pullPolicy: IfNotPresent
  tag: "1.34"

@simar7
Copy link
Member

simar7 commented Jul 17, 2023

@simar7 We just need to run publish-chart action, right?

UPD: I checked - Aqua Chart Repository still uses old version:

➜  ~ helm helm repo update
➜  ~ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "aquasecurity" chart repository
Update Complete. ⎈Happy Helming!⎈
➜  ~ helm show values aquasecurity/postee --version v2.12.0 | grep tag: -B 3
    # usernameKey: username
    # passwordKey: password
  image: aquasec/postee-ui
  tag: "2.8.4-amd64"
--
image:
  repository: aquasec/postee
  pullPolicy: Always
  tag: "2.8.4-amd64"
imageInit:
  repository: busybox
  pullPolicy: IfNotPresent
  tag: "1.34"

I cut a new release and the new chart was published https://github.com/aquasecurity/postee/actions/runs/5576434122/jobs/10187702366

Could you check again?

@DmitriyLewen
Copy link
Collaborator Author

helm repo still doesn't contains v2.13.0:

➜  ~ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "aquasecurity" chart repository
Update Complete. ⎈Happy Helming!⎈
➜  ~ helm search repo aquasecurity -l | grep v2.1
aquasecurity/postee              	v2.12.0      	v2.12.0    	A Helm chart for Postee                           
aquasecurity/postee              	v2.11.2      	v2.11.2    	A Helm chart for Postee                           
aquasecurity/postee              	v2.11.1      	v2.11.1    	A Helm chart for Postee                           
aquasecurity/postee              	v2.11.0      	v2.11.0    	A Helm chart for Postee                           
aquasecurity/postee              	v2.10.2      	v2.10.2    	A Helm chart for Postee                           
aquasecurity/postee              	v2.1.0       	v2.1.0     	A Helm chart for Postee

But aquasecurity/helm-charts contains v2.13.0 release - https://github.com/aquasecurity/helm-charts/releases/tag/postee-v2.13.0.
I installed postee from release file:

➜  helm install app --create-namespace -n postee postee-v2.13.0.tgz 
...

➜  kubectl get pods -n postee -o jsonpath="{.items[*].spec.containers[*].image}"
aquasec/postee:2.12.0-amd64 aquasec/postee-ui:2.12.0-amd64%

It works correctly.

If i understand correctly - we need to wait when https://aquasecurity.github.io/helm-charts/ page will be updated (https://github.com/aquasecurity/helm-charts/actions/workflows/pages/pages-build-deployment)

@simar7
Copy link
Member

simar7 commented Jul 18, 2023

helm repo still doesn't contains v2.13.0:


➜  ~ helm repo update

Hang tight while we grab the latest from your chart repositories...

...Successfully got an update from the "aquasecurity" chart repository

Update Complete. ⎈Happy Helming!⎈

➜  ~ helm search repo aquasecurity -l | grep v2.1

aquasecurity/postee              	v2.12.0      	v2.12.0    	A Helm chart for Postee                           

aquasecurity/postee              	v2.11.2      	v2.11.2    	A Helm chart for Postee                           

aquasecurity/postee              	v2.11.1      	v2.11.1    	A Helm chart for Postee                           

aquasecurity/postee              	v2.11.0      	v2.11.0    	A Helm chart for Postee                           

aquasecurity/postee              	v2.10.2      	v2.10.2    	A Helm chart for Postee                           

aquasecurity/postee              	v2.1.0       	v2.1.0     	A Helm chart for Postee

But aquasecurity/helm-charts contains v2.13.0 release - https://github.com/aquasecurity/helm-charts/releases/tag/postee-v2.13.0.

I installed postee from release file:


➜  helm install app --create-namespace -n postee postee-v2.13.0.tgz 

...



➜  kubectl get pods -n postee -o jsonpath="{.items[*].spec.containers[*].image}"

aquasec/postee:2.12.0-amd64 aquasec/postee-ui:2.12.0-amd64%

It works correctly.

If i understand correctly - we need to wait when https://aquasecurity.github.io/helm-charts/ page will be updated (https://github.com/aquasecurity/helm-charts/actions/workflows/pages/pages-build-deployment)

Hmmm do you know what triggers this action? Seems like it was triggered 5 days ago.

@DmitriyLewen
Copy link
Collaborator Author

I can't find this information, because helm-chart doesn't use .github folder with workflow configs.
I asked about this here.

I'll write to you after answering or updating GH-pages.

@thiagolinhares
Copy link

helm repo still not updated. Any updates on this?

@DmitriyLewen
Copy link
Collaborator Author

hm... strange case.
Looks like our action didn't update index.yaml.

@simar7 Can we try to rerun publish action or will that not help?

@simar7
Copy link
Member

simar7 commented Aug 28, 2023

hm... strange case. Looks like our action didn't update index.yaml.

@simar7 Can we try to rerun publish action or will that not help?

I've released a new version, it should be available now

 helm search repo aquasecurity -l | grep v2.14
aquasecurity/postee                     v2.14.0         v2.14.0         A Helm chart for Postee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitriyLewen @simar7 @thiagolinhares