Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): loading config file #3370

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Aug 10, 2023

1. Explain what the PR does

Fix #3369

By disabling argument parsing https://github.com/aquasecurity/tracee/blob/main/cmd/tracee/cmd/root.go#L28, we stopped loading the config file properly.

2. Explain how to test it

tracee --config cfg.yaml

3. Other comments

This needs to be backported to the 0.17.0 and we need a bugfix release.

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • --help flag still working
  • --config worked
  • other flags without --config worked
  • as before, cli flags override the properties of a --config file, but the rest of the config remains being defined.

LGTM

@josedonizetti josedonizetti merged commit 7e58610 into aquasecurity:main Aug 10, 2023
26 checks passed
@josedonizetti josedonizetti deleted the fix-config-loading branch August 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracee is not loading a config file
2 participants