Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracee rpc service #3389

Merged

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Aug 15, 2023

Adds tracee rpc service with a first endpoint to return tracee's version

1. Explain what the PR does

This is the first PR to support a v1 for GRPC. It adds a Tracee rpc service with an endpoint to return its version. The rpc now is declared as v1beta1 because we are still discussing the endpoints, but once we decide it we will be changing it to be v1.

The PR also adds a Makefile target to generate the code from the proto definition.

"Replace me with make check-pr output"

2. Explain how to test it

# do a change to the proto file
make -f builder/Makefile.protoc 

3. Other comments

types/api/v1beta1/tracee.proto Show resolved Hide resolved
Makefile Show resolved Hide resolved
Adds tracee rpc service with a first endpoint to return tracee's version
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested:

image

@josedonizetti josedonizetti merged commit 7c72262 into aquasecurity:main Aug 16, 2023
24 of 25 checks passed
@josedonizetti josedonizetti deleted the add-tracee-version-rpc branch August 16, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants