Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ebpf): fix hidden_kernel_module not found symbol #3834

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(ebpf): fix hidden_kernel_module not found symbol #3834

merged 1 commit into from
Feb 22, 2024

Conversation

OriGlassman
Copy link
Collaborator

1. Explain what the PR does

Change hidden_kernel_module logic so that it's not based on layout_and_allocate symbol which is not always present in all kernels

2. Explain how to test it

./tracee -e=hidden_kernel_module

3. Other comments

AlonZivony
AlonZivony suggested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@AlonZivony AlonZivony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great.
Only issue is using consts for all error values.

pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
@OriGlassman OriGlassman force-pushed the ker_mod_change branch 4 times, most recently from 3bf6bcd to 424b21c Compare February 4, 2024 09:29
AlonZivony
AlonZivony suggested changes Feb 7, 2024
View reviewed changes
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Outdated Show resolved Hide resolved
@OriGlassman OriGlassman force-pushed the ker_mod_change branch 4 times, most recently from 9e5afb4 to 45674b7 Compare February 8, 2024 13:28
AlonZivony
AlonZivony approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@AlonZivony AlonZivony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqua-ci
Copy link

aqua-ci commented Feb 8, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0c86a42b0f61bd86e_3834-7830367353_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 8, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-071a53e3ad06e6a7e_3834-7830367353_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Feb 8, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0b66222a60f8f97be_3834-7830367353_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@geyslan
Copy link
Member

geyslan commented Feb 21, 2024

We have this update #3875

Please rebase your PR against main to make use of the new workflow setup.

@OriGlassman
Copy link
Collaborator Author

We have this update #3875

Please rebase your PR against main to make use of the new workflow setup.

Rebased

yanivagman
yanivagman approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivagman yanivagman merged commit 5cb5760 into aquasecurity:main Feb 22, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan left review comments

@yanivagman yanivagman yanivagman approved these changes

@AlonZivony AlonZivony AlonZivony approved these changes

Assignees

@OriGlassman OriGlassman

Labels
area/ebpf area/events
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OriGlassman @aqua-ci @geyslan @yanivagman @AlonZivony