chore!: remove gob support from tracee-rules #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finishes the removal of gob support after aquasecurity#3841.
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Mar 28, 2024
When policies version was implemented, the initial idea was to pass the policies pointer in the event, so that the correct policies version could be reused at each stage of the pipeline without having to retrieve it from the snapshots every time. However, this was not possible at the time since the gob library does not support unsafe.Pointer types. After aquasecurity#3939, Tracee no longer uses gob, so the policies pointer can be passed in the event as originally intended.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
ec64498 chore!: remove gob support from tracee-rules
2. Explain how to test it
3. Other comments