New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(image): add `--docker-host` option for GH Action users #267

Merged

simar7 merged 3 commits into aquasecurity:master from calinmarina:feat/addDockerHost

Apr 3, 2024

Contributor

calinmarina commented Oct 10, 2023 •

edited

Loading

This is addressing problem arising from trying to scan local images when docker socket path is different than default /var/run/docker.sock

This was already requested and solved here aquasecurity/trivy#2997 for CLI runs but not available for trivy GH Action.

Adds test and fixes outdated ones.

CLAassistant commented Oct 10, 2023 •

edited

Loading

All committers have signed the CLA.

calinmarina added 2 commits

October 10, 2023 22:21


          add option to update docker-host via cli parameter

430ebd8


          chore: update test results

129ed55

calinmarina force-pushed the feat/addDockerHost branch from 5ad2b81 to 129ed55 Compare

October 10, 2023 21:22

Contributor

admiralAwkbar commented Apr 3, 2024

Would you be able to get this merged back to master?
Seems like an easy PR fix, and solves my issue in my current work as our docker-hosted runners mount on /run/docker/docker.sock

Thanks!

Contributor

uridium commented Apr 3, 2024

@admiralAwkbar it's not up to me, but @simar7


          Merge branch 'master' into feat/addDockerHost

a5562a9

simar7 self-requested a review

April 3, 2024 23:25

simar7 approved these changes

View reviewed changes

Member

simar7 left a comment

thanks, lgtm! sorry about the delay in reviewing.

simar7 merged commit 0f287db into aquasecurity:master

1 of 2 checks passed

admiralAwkbar mentioned this pull request

Fix docker host bug #329

Merged

Kieffer87 mentioned this pull request

Bump aquasecurity/trivy-action from 0.19.0 to 0.20.0 tkhom3/gha-workflows#31

Merged

ashnamehrotra mentioned this pull request

Add examples for scanning when using docker/setup-buildx-action project-copacetic/copa-action#45

Open

juanjjaramillo referenced this pull request in newrelic/helm-charts


          chore(deps): update aquasecurity/trivy-action action to v0.24.0 (#1356)

40f8053

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[aquasecurity/trivy-action](https://togithub.com/aquasecurity/trivy-action)
| action | minor | `0.19.0` -> `0.24.0` |

---

### Release Notes

<details>
<summary>aquasecurity/trivy-action (aquasecurity/trivy-action)</summary>

###
[`v0.24.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.24.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.23.0...0.24.0)

#### What's Changed

- Upgrade trivy to v0.53.0 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/369](https://togithub.com/aquasecurity/trivy-action/pull/369)

**Full Changelog**:
aquasecurity/trivy-action@0.23.0...0.24.0

###
[`v0.23.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.23.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.22.0...0.23.0)

#### What's Changed

- Upgrade trivy to v0.52.2 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/367](https://togithub.com/aquasecurity/trivy-action/pull/367)

**Full Changelog**:
aquasecurity/trivy-action@0.22.0...0.23.0

###
[`v0.22.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.22.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.21.0...0.22.0)

#### What's Changed

- chore(docs): Reference the use of a pinned version by
[@&#8203;simar7](https://togithub.com/simar7) in
[https://github.com/aquasecurity/trivy-action/pull/356](https://togithub.com/aquasecurity/trivy-action/pull/356)
- Upgrade trivy to v0.52.0 by
[@&#8203;Keralin](https://togithub.com/Keralin) in
[https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364)

#### New Contributors

- [@&#8203;Keralin](https://togithub.com/Keralin) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364)

**Full Changelog**:
aquasecurity/trivy-action@0.21.0...0.22.0

###
[`v0.21.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.21.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.20.0...0.21.0)

#### What's Changed

- bump trivy version to v0.51.2 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360)

#### New Contributors

- [@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360)

**Full Changelog**:
aquasecurity/trivy-action@0.20.0...0.21.0

###
[`v0.20.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.20.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.19.0...0.20.0)

##### What's Changed

- Make 'hide-progress' input working again by
[@&#8203;uridium](https://togithub.com/uridium) in
[https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323)
- feat(image): add `--docker-host` option for GH Action users by
[@&#8203;calinmarina](https://togithub.com/calinmarina) in
[https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267)
- Browse Trivy reports without GitHub Advanced Security license by
[@&#8203;uridium](https://togithub.com/uridium) in
[https://github.com/aquasecurity/trivy-action/pull/328](https://togithub.com/aquasecurity/trivy-action/pull/328)
- Fix docker host bug by
[@&#8203;admiralAwkbar](https://togithub.com/admiralAwkbar) in
[https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329)
- Bump trivy version to v0.50.2 by
[@&#8203;pdefreitas](https://togithub.com/pdefreitas) in
[https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341)
- update tests by [@&#8203;nikpivkin](https://togithub.com/nikpivkin) in
[https://github.com/aquasecurity/trivy-action/pull/334](https://togithub.com/aquasecurity/trivy-action/pull/334)
- bump trivy version to v0.51.1 by
[@&#8203;simar7](https://togithub.com/simar7) in
[https://github.com/aquasecurity/trivy-action/pull/353](https://togithub.com/aquasecurity/trivy-action/pull/353)

##### New Contributors

- [@&#8203;uridium](https://togithub.com/uridium) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323)
- [@&#8203;calinmarina](https://togithub.com/calinmarina) made their
first contribution in
[https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267)
- [@&#8203;admiralAwkbar](https://togithub.com/admiralAwkbar) made their
first contribution in
[https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329)
- [@&#8203;pdefreitas](https://togithub.com/pdefreitas) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341)

**Full Changelog**:
aquasecurity/trivy-action@0.19.0...0.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy40MjUuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet