Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-arch docker images. #496

Closed
Johannestegner opened this issue May 15, 2020 · 4 comments
Closed

Multi-arch docker images. #496

Johannestegner opened this issue May 15, 2020 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@Johannestegner
Copy link
Contributor

Hi there!

I would like to request multi-arch docker images, seeing the releases page have basically all architectures one could wish for, this should not be a huge issue to implement!

I would think that at the least aarch64 and possibly a couple of the 32b ARM cpu's would be the initial most-required versions if this is to be implemented, and if there is no experience in the field of multi-arch images I'd recommend taking a look at buildx with qemu support.

If you need any type of help with setting something up, let me know and I'll happily help!

Until implemented or requested for takedown:

As of now (due to me using both amd64 and arm64 machines in my ci-fleet) I created an image for amd64 and aarch64 cpus which could be found here (for anyone who requires it til it is implemented on the official channel!): https://hub.docker.com/repository/docker/jitesoft/trivy

Image is built from source on native machines and are ofc scanned with Trivy to make sure there are no vulnerabilities! ;)
@Johannestegner Johannestegner added the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2020
@dasrecht dasrecht mentioned this issue Mar 20, 2021
Closed
@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Mar 22, 2021
@krol3 krol3 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. labels Mar 22, 2021
@knqyf263 knqyf263 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 22, 2021
@knqyf263
Copy link
Collaborator

I think we can easily do that with GoReleaser. You can see a good example here.
https://github.com/goreleaser/goreleaser/blob/5e23177a4c6837a75f76acce237f2c10f35b9819/.goreleaser.yml#L35-L83

@knqyf263 knqyf263 added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Mar 22, 2021
@ocean ocean mentioned this issue Mar 25, 2021
Merged
@ocean
Copy link
Contributor

ocean commented Mar 25, 2021

@knqyf263 I've taken up your suggestion and got it working great with some extra Goreleaser config and adding Docker Buildx support to the release workflow, thanks for the inspiration 😄

Please see #915 🚀

@knqyf263
Copy link
Collaborator

See the release note.
#966

josedonizetti pushed a commit to josedonizetti/trivy that referenced this issue Jun 24, 2022
@liamg
feat(cf): Add support for AES256 enryption for s3 bucket in cloudform…
15ff5d8 
…ation (aquasecurity#496)

Resolves aquasecurity#452

Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>
@YOU54F YOU54F mentioned this issue Apr 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ocean @knqyf263 @Johannestegner @krol3