Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spdx): rename describes field in spdx #3102

Merged
merged 1 commit into from
Nov 13, 2022
Merged

fix(spdx): rename describes field in spdx #3102

merged 1 commit into from
Nov 13, 2022

Conversation

DmitriyLewen
Copy link
Contributor

Description

There is mistake in DESCRIBES field in SPDX.
https://spdx.github.io/spdx-spec/relationships-between-SPDX-elements/#1111-description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen mentioned this pull request Nov 1, 2022
Closed
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 1, 2022 11:10
manifestori
manifestori approved these changes Nov 2, 2022
View reviewed changes
Copy link

@manifestori manifestori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://spdx.dev/wp-content/uploads/sites/41/2020/08/SPDX-specification-2-2.pdf

LGTM

@knqyf263 knqyf263 merged commit 6da148c into main Nov 13, 2022
@knqyf263 knqyf263 deleted the fix/spdx-describes branch November 13, 2022 10:59
@tusharkshatriya tusharkshatriya mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@manifestori manifestori manifestori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CRITICAL] Output uses 'DESCRIBE' not 'DESCRIBES' which doesn't match SPDX spec
3 participants
@DmitriyLewen @knqyf263 @manifestori