Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbom): add primary package purpose field for SPDX #4119

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Apr 25, 2023

Description

Add primary package purpose

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Comment on lines 91 to 96
var ApplicationTypes = []string{
GoBinary,
RustBinary,
Jar,
NodePkg,
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this way.
I had idea: use struct instead of string for Type field.
Something like this:

type Type struct {
	name  string
	isApp bool // true for `jar`, `goBinary`, etc...
}

@DmitriyLewen DmitriyLewen changed the title feat(sbom): add primary package purpose field feat(sbom): add primary package purpose field for SPDX Apr 25, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review April 25, 2023 08:57
@DmitriyLewen DmitriyLewen self-assigned this Apr 25, 2023
@knqyf263 knqyf263 merged commit 5eab464 into aquasecurity:main Apr 25, 2023
@DmitriyLewen DmitriyLewen deleted the feat/sbom-package-purpose branch April 26, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants