Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support registry token #482

Merged
merged 11 commits into from
May 19, 2020
Merged

feat: support registry token #482

merged 11 commits into from
May 19, 2020

Conversation

knqyf263
Copy link
Collaborator

Close #453

@knqyf263 knqyf263 added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Apr 30, 2020
@knqyf263 knqyf263 added this to the v0.7.0 milestone Apr 30, 2020
@knqyf263 knqyf263 requested a review from simar7 April 30, 2020 12:27
@knqyf263 knqyf263 self-assigned this Apr 30, 2020
@knqyf263 knqyf263 added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Apr 30, 2020
@@ -0,0 +1,112 @@
package docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the functions in this file used besides in a test? Maybe I missed something here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is completely for testing. I copied this file from https://github.com/aquasecurity/harbor-scanner-trivy/blob/master/test/component/docker/docker.go. I separated the package so that it can be used from some tests.

@knqyf263 knqyf263 modified the milestones: v0.7.0, v0.8.0 May 18, 2020
@simar7 simar7 self-requested a review May 19, 2020 16:31
@knqyf263 knqyf263 merged commit 926f323 into master May 19, 2020
@knqyf263 knqyf263 deleted the support_bearer_token branch May 19, 2020 17:49
GuaoGuao pushed a commit to GuaoGuao/trivy that referenced this pull request Jun 24, 2020
* feat: support registry token

* chore(mod): update

* test(integration): add registry tests

* chore(mod): update

* test(integration): comment in terminate

Co-authored-by: Simarpreet Singh <simar@linux.com>
liamg pushed a commit that referenced this pull request Jun 7, 2022
* feat: support registry token

* chore(mod): update

* test(integration): add registry tests

* chore(mod): update

* test(integration): comment in terminate

Co-authored-by: Simarpreet Singh <simar@linux.com>
josedonizetti pushed a commit to josedonizetti/trivy that referenced this pull request Jun 24, 2022
* build(actions): Build/test on Windows/MacOS/Linux

Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>

* fix: Fix tests on windows

* fix: Fix racy test

* chore(memoryfs): Update to latest memoryfs

* fix: Fix module source prefix detection for local

* remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docker registry token
2 participants