Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix a compile error with Go 1.21 #5339

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Oct 5, 2023

Description

go get go@1.20 downgrades the required Go version and the dependency versions (github.com/sigstore/rekor this time). See the comment for details.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Oct 5, 2023
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review October 5, 2023 08:48
@knqyf263 knqyf263 added this pull request to the merge queue Oct 5, 2023
aminvakil added a commit to aminvakil/aur that referenced this pull request Oct 5, 2023
@aminvakil
Copy link

aminvakil commented Oct 5, 2023

I've opened aminvakil/aur#308 to test on go 1.21 and my environment after patching this PR.

@aminvakil
Copy link

And I just saw that is going to be merged :) I'll report here anyway, thanks!

Copy link

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged via the queue into aquasecurity:main with commit 008babf Oct 5, 2023
12 checks passed
@knqyf263 knqyf263 deleted the go121 branch October 5, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: fix a compile error with Go 1.21
3 participants