Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix error when installing PyYAML for gh pages #5462

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

There is problem with old PyYAML and Python 3.12.
PyYAML 6.0.1 works correctly in Python 3.12 - yaml/pyyaml#760 (comment)

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen changed the title docs: fix error with install PyYAML for gh pages docs: fix error when installing PyYAML for gh pages Oct 27, 2023
Copy link
Contributor Author

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knqyf263 I fixed error with docs workflows after update Python to 3.12 (in actions/setup-python@v4).

But after these changes i thought that perhaps we want just lock Python version on 3.11?
Python will support 3.11 until 2027 year -https://devguide.python.org/versions/

@@ -21,6 +21,7 @@ jobs:
python-version: 3.x
- name: Install dependencies
run: |
python -m pip install --upgrade pip setuptools wheel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
FROM squidfunk/mkdocs-material:8.3.9
FROM squidfunk/mkdocs-material:9.4.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squidfunk/mkdocs-material:9.4.6 (new version) also returns error for PyYAML 6.0.0.
Updated it to avoid conflicts with new PyYAML version other packages after subsequent Python updates.

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 27, 2023 06:08
@DmitriyLewen DmitriyLewen mentioned this pull request Oct 27, 2023
6 tasks
@knqyf263
Copy link
Collaborator

We'll face the same problem in 2027. It is good to bump Python.

@knqyf263 knqyf263 added this pull request to the merge queue Oct 28, 2023
Merged via the queue into aquasecurity:main with commit 013d901 Oct 28, 2023
17 checks passed
@knqyf263
Copy link
Collaborator

knqyf263 commented Oct 28, 2023

Thanks for your great fix, @DmitriyLewen,

@DmitriyLewen DmitriyLewen deleted the docs/fix-pyyaml-install-error branch October 30, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants