Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow adjustment of Trivy K8S Client QPS/Burst with --qps and --burst flags #5910

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: allow adjustment of Trivy K8S Client QPS/Burst with --qps and --burst flags #5910

merged 1 commit into from
Jan 15, 2024

Conversation

thapabishwa
Copy link
Contributor

@thapabishwa thapabishwa commented Jan 10, 2024 •
edited
Loading

Description

This aims to allow users to adjust K8S Client QPS and Burst value.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@thapabishwa thapabishwa marked this pull request as ready for review January 10, 2024 13:27
@knqyf263
Copy link
Collaborator

@chen-keinan Would you take a look?

chen-keinan
chen-keinan reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thapabishwa lgtm , I have added one comment

go.mod Outdated Show resolved Hide resolved
@chen-keinan
Copy link
Contributor

@thapabishwa lgtm 🚀

@knqyf263 knqyf263 added this pull request to the merge queue Jan 15, 2024
Merged via the queue into aquasecurity:main with commit 2c9d7c6 Jan 15, 2024
17 checks passed
@thapabishwa thapabishwa deleted the k8s-burst-qps branch January 19, 2024 08:25
@thapabishwa thapabishwa changed the title feat: allow end-users to adjust K8S client QPS and burst feat: allow adjustment of Trivy K8S Client QPS/Burst with --qps and --burst flags Mar 26, 2024
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen-keinan chen-keinan chen-keinan approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thapabishwa @knqyf263 @chen-keinan