Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): use group field for pom.xml and nodejs files for CycloneDX reports #5922

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

We separate GroupID and ArtifactID to group and name fields for jar files - #4674
But we need to use same logic for all Java files.

Also we need to store nodejs scopes to group fields (see #5908).

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jan 11, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review January 11, 2024 11:23
@knqyf263 knqyf263 added this pull request to the merge queue Jan 15, 2024
Merged via the queue into aquasecurity:main with commit c75143f Jan 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use group fields for npm for CycloneDX
2 participants