Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): add support for line numbers for pom.xml files #5991

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jan 24, 2024

Description

Add support for line numbers for pom.xml files.

This PR only adds locations for the base pom.xml file dependencies.
Modules, nested dependencies and GAV of the base pom.xml don't have locations.

example:

{
  ...
  "Results": [
    {
      "Target": "pom.xml",
      "Class": "lang-pkgs",
      "Type": "pom",
      "Packages": [
        {
          "ID": "com.example:log4shell:1.0-SNAPSHOT",
          "Name": "com.example:log4shell",
          "Identifier": {
            "PURL": "pkg:maven/com.example/log4shell@1.0-SNAPSHOT"
          },
          "Version": "1.0-SNAPSHOT",
          "DependsOn": [
            "com.fasterxml.jackson.core:jackson-databind:2.9.1"
          ],
          "Layer": {}
        },
        ...
        {
          "ID": "com.fasterxml.jackson.core:jackson-databind:2.9.1",
          "Name": "com.fasterxml.jackson.core:jackson-databind",
          "Identifier": {
            "PURL": "pkg:maven/com.fasterxml.jackson.core/jackson-databind@2.9.1"
          },
          "Version": "2.9.1",
          "Licenses": [
            "The Apache Software License, Version 2.0"
          ],
          "DependsOn": [
            "com.fasterxml.jackson.core:jackson-annotations:2.9.0",
            "com.fasterxml.jackson.core:jackson-core:2.9.1"
          ],
          "Layer": {},
          "Locations": [
            {
              "StartLine": 41,
              "EndLine": 45
            }
          ]
        }
      ]
    }
  ]
}

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jan 24, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review January 24, 2024 12:19
@knqyf263 knqyf263 added this pull request to the merge queue Jan 25, 2024
Merged via the queue into aquasecurity:main with commit b4b90cf Jan 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven line number support (pom.xml)
2 participants