Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): use project dir when searching for workspaces for Yarn.lock files #6102

Conversation

DmitriyLewen
Copy link
Contributor

Description

package.json files don't use project dir in workspace patterns.
But we are required to add to use correctly patters for Glob() funtion.
e.g.:
fs:

.
└── foo
    ├── bar
    │   └── generators
    │       └── package.json
    ├── package.json
    └── yarn.lock

./foo/package.json file uses bar/* pattern.
But we need to use foo/bar/* pattern to correctly match the workspace path for our fs.

We don't see this error when scanning the project directory because in this case rootdir is ..

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Feb 12, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 12, 2024 10:18
@knqyf263 knqyf263 added this pull request to the merge queue Feb 13, 2024
Merged via the queue into aquasecurity:main with commit 3ac6388 Feb 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(yarn): workspaces are not detected if you scan non project directory
2 participants