fix(nodejs): use project dir when searching for workspaces for Yarn.lock files #6102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package.json
files don't use project dir in workspace patterns.But we are required to add to use correctly patters for
Glob()
funtion.e.g.:
fs
:./foo/package.json
file usesbar/*
pattern.But we need to use
foo/bar/*
pattern to correctly match the workspace path for ourfs
.We don't see this error when scanning the project directory because in this case rootdir is
.
.Related issues
Checklist