Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): Support for detecting Hugging Face Access Tokens #6236

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

chrisking
Copy link
Contributor

@chrisking chrisking commented Feb 29, 2024

Description

Hugging Face Access Tokens are not detected by the scanner for secrets yet, I added them as an entity with this change and provided a test case as well.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • [] I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chrisking
Thnka for your work!

I left comments. Take a look, when you have time, please.

Regards, Dmitriy

pkg/fanal/secret/builtin-rules.go Outdated Show resolved Hide resolved
pkg/fanal/secret/scanner_test.go Outdated Show resolved Hide resolved
pkg/fanal/secret/builtin-rules.go Outdated Show resolved Hide resolved
@chrisking
Copy link
Contributor Author

chrisking commented Mar 4, 2024

Thanks for the help @DmitriyLewen , I really appreciate the extra help to get this code up to the standards for Trivy.

@knqyf263 , let me know if there's anything missing from your perspective.

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knqyf263 take a look, when you have time.

@knqyf263 knqyf263 added this pull request to the merge queue Mar 7, 2024
Merged via the queue into aquasecurity:main with commit 6639911 Mar 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret Detection Addition: HuggingFace Access Tokens
4 participants