fix(terraform): fix policy document retrieval #6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Mar 8, 2024
Comment on lines
211
to
212
| policyDoc, err := modules.GetBlockById(policyDocID) | ||
| if err == nil { |
There was a problem hiding this comment.
nit:
Suggested change
| policyDoc, err := modules.GetBlockById(policyDocID) | |
| if err == nil { | |
| if policyDoc, err := modules.GetBlockById(policyDocID); err == nil { |
simar7
reviewed
Mar 8, 2024
Comment on lines
213
to
214
| document, err := ConvertTerraformDocument(modules, policyDoc) | ||
| if err == nil { |
There was a problem hiding this comment.
nit:
Suggested change
| document, err := ConvertTerraformDocument(modules, policyDoc) | |
| if err == nil { | |
| if document, err := ConvertTerraformDocument(modules, policyDoc); err == nil { |
simar7
reviewed
Mar 8, 2024
Comment on lines
218
to
219
| parsed, err := iamgo.Parse([]byte(unescapeVars(policyDocID))) | ||
| if err == nil { |
There was a problem hiding this comment.
nit:
Suggested change
| parsed, err := iamgo.Parse([]byte(unescapeVars(policyDocID))) | |
| if err == nil { | |
| if parsed, err := iamgo.Parse([]byte(unescapeVars(policyDocID))); err == nil { |
simar7
reviewed
Mar 8, 2024
Comment on lines
+205
to
+207
| if !attr.IsIterable() { | ||
| return documents | ||
| } |
simar7
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a policy, such as
aws_iam_policyoraws_iam_policy_document, uses a for-each loop to reference policy document resources, those resources are not detected. In the case where a policy references document resources in a condition, only the first resource was selected. It is necessary to search for policy document resources by identifiers (id) rather than by references to fix this.Related issues
Checklist