Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misconf): remove file filtering from parsers #7289

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 1, 2024

Description

This PR removes duplicate file filtering from the parsers, which was never done because a flag was always passed to disable it. Currently, the detection package is responsible for this, which filters files before scanning.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review August 1, 2024 08:57
@knqyf263 knqyf263 added this pull request to the merge queue Aug 2, 2024
Merged via the queue into aquasecurity:main with commit e95152f Aug 2, 2024
13 checks passed
@nikpivkin nikpivkin deleted the iac-required branch August 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants