Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sidedrawer help with NativeScript upgrades - ({N} 7 + ng 10.1) #1

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

NathanWalker
Copy link
Contributor

@aquinn637 I went ahead and upgraded the project to {N} 7 and Angular 10.1 with working sidedrawer. Perhaps this helps show you the changes needed as well as others in similar situation. 🤝 🤗

nativescript-support-help-sidedrawer-ns-7

@aquinn637
Copy link
Owner

@NathanWalker I merged in the pull request and pull the code into my local repo.
I ran npm i and then ns build android.

There was an error:

ns build android

Preparing project...

Using @nativescript/android which requires nsconfig.json to be present.
Writing nsconfig.json based on the values set in nativescript.config.(js|ts).
You may add nsconfig.json to .gitignore as the CLI will regenerate it as necessary.

Compiling @angular/core : module as esm2015
Compiling @angular/animations : module as esm2015
Compiling @angular/common : module as esm2015
Compiling @angular/animations/browser : module as esm2015
Compiling @angular/platform-browser : module as esm2015
Compiling @angular/router : module as esm2015
Compiling @angular/forms : module as esm2015
Compiling @angular/platform-browser/animations : module as esm2015
Compiling @angular/common/http : module as esm2015
Compiling @nativescript/angular : module as esm2015
Compiling nativescript-ui-sidedrawer-angular : module as esm2015
Error: Error on worker #1: Error: The given rootPath undefined is not a file of the program.
    at getRootFileOrFail (/Users/aubrey/Documents/GitHub/Angular9SideDrawer/node_modules/@angular/compiler-cli/ngcc/src/host/esm2015_host.js:2322:19)

ns --version
7.0.8

node -v
v10.19.0

npm list -g --depth 0
/usr/local/lib
├── @angular/cli@10.1.1
├── @nativescript/schematics@10.1.0
├── cordova@10.0.0
├── cordova-res@0.15.1
├── eslint@7.9.0
├── gulp@4.0.2
├── ionic@4.10.3
├── ios-deploy@1.10.0
├── ios-sim@9.0.0
├── jshint@2.12.0
├── jslint@0.12.1
├── karma-cli@2.0.0
├── native-run@1.0.0
├── nativescript@7.0.8
├── npm@6.14.4
├── plugman@3.0.1
├── tslint@6.1.3
├── typescript@4.0.2
├── UNMET PEER DEPENDENCY webpack@4.x.x
└── webpack-cli@3.3.12

MacOS

@limyandi
Copy link

If you have ngcc.config.ts/js , you can delete them and that would fix it
ProgressNS/nativescript-ui-feedback#1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants