Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commands/init): throw meaningful error if project folder already exists #164

Merged
merged 2 commits into from
Aug 8, 2018
Merged

fix(commands/init): throw meaningful error if project folder already exists #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89cc7d7
fix(commands/init): throw meaningful error if project folder already …
0x-r4bbit Aug 7, 2018
22b1763
fix(commands/init): fix 'Checking project existence' duplicated in th…
izqui Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/commands/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,23 @@ exports.handler = function ({ reporter, name, template }) {

const basename = name.split('.')[0]
const tasks = new TaskList([
{
title: 'Checking project existence',
task: async (ctx, task) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctx and task aren't really used here, but have been provided in other tasks that didn't use them as well. I just stuck to your style. Let me know if you want me to remove those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep them for consistency :)

const projectPath = path.resolve(process.cwd(), basename)
const exists = await fs.pathExists(projectPath)
if (exists) {
throw new Error(`Couldn't initialize project. Project with name ${basename} already exists in ${projectPath}. Use different <name> or rename existing project folder.`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First stab on meaningful error message. Happy to add better wording here if anyone has strong opinions :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}
}
},
{
title: 'Clone template',
task: async (ctx, task) => {
task.output = `Cloning ${template} into ${basename}...`

const repo = await clone(template, basename, { shallow: true })
console.log(`Template cloned to ${basename}`)
// console.log(`Template cloned to ${basename}`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about removing it entirely instead of leaving a comment here @izqui ? :)

Also, would you mind enlighten me how having this console.log causes multiple outputs of a totally different task?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your are absolutely right, forgot to remove it after testing. Fixed: #165

TaskList basically hijacks the console output and if you try to print in a different way, the output gets fucked up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskList basically hijacks the console output and if you try to print in a different way, the output gets fucked up.

Wow.. I had no idea. Thanks!

}
},
{
Expand Down