Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive list of templates to choose from to resolve #812 #832

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

dapplion
Copy link
Contributor

🦅 Pull Request

Shows an interactive list of template options if no template positional argument is passed when calling create-aragon-app. Demo:

? Chose a template to scaffold from (Use arrow keys)
❯ Aragon bare boilerplate 
  Aragon React boilerplate 
  Your first Aragon app (tutorial) 

If silent = true, the template react is used requiring no interaction.
Also added the template options dynamically to the command documentation:

Create a new aragon application

Positionals:
  name      The application name (appname.aragonpm.eth)
  template  The template to scaffold from (bare, react, tutorial)

🚨 Test instructions

Run create-aragon-app without providing a template

✔️ PR Todo

@dapplion dapplion requested a review from 0xGabi as a code owner October 23, 2019 21:44
@welcome
Copy link

welcome bot commented Oct 23, 2019

Thanks for opening this pull request! Someone will review it soon 🔍

Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dapplion. I reviewed it and is working great and make things much user friendly 🎉

What you think if we take the opportunity to also add this #831 in case React or bare boilerplates are chosen?

@dapplion dapplion changed the title Add interactive list of templates to choose from Add interactive list of templates to choose from to resolve #812 Oct 24, 2019
@0xGabi
Copy link
Contributor

0xGabi commented Oct 24, 2019

@dapplion we can merge this one and work on a new PR for the extra changes

@0xGabi 0xGabi merged commit e4ccf6c into aragon:master Oct 24, 2019
@welcome
Copy link

welcome bot commented Oct 24, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

@dapplion dapplion deleted the 812_list_create branch October 27, 2019 16:18
@dapplion
Copy link
Contributor Author

Sounds good, I'll do a new PR with your suggestion. Stoked for this first merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants