Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracts logic from dao commands #874

Merged
merged 19 commits into from
Dec 4, 2019
Merged

Extracts logic from dao commands #874

merged 19 commits into from
Dec 4, 2019

Conversation

macor161
Copy link
Contributor

@macor161 macor161 commented Nov 6, 2019

🦅 Pull Request

@macor161 macor161 mentioned this pull request Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@114dc26). Click here to learn what that means.
The diff coverage is 31.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #874   +/-   ##
=========================================
  Coverage           ?   22.5%           
=========================================
  Files              ?     112           
  Lines              ?    2453           
  Branches           ?       0           
=========================================
  Hits               ?     552           
  Misses             ?    1901           
  Partials           ?       0
Impacted Files Coverage Δ
packages/aragon-cli/src/lib/dao/exec.js 0% <0%> (ø)
packages/aragon-cli/src/lib/dao/utils.js 0% <0%> (ø)
...ckages/aragon-cli/src/commands/dao_cmds/upgrade.js 0% <0%> (ø)
...ckages/aragon-cli/src/commands/dao_cmds/install.js 0% <0%> (ø)
packages/aragon-cli/src/lib/dao/kernel.js 62.5% <62.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114dc26...35e3376. Read the comment docs.

@0xGabi 0xGabi changed the title WIP Extracts logic from dao commands Extracts logic from dao commands Dec 4, 2019
@0xGabi 0xGabi merged commit 7e08b55 into develop Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor-dao-commands branch December 4, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants