Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic for "token change-controller" command #972

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

macor161
Copy link
Contributor

🦅 Pull Request

Ref #947

🚨 Test instructions

dao token change-controller

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #972 into develop will increase coverage by 0.33%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #972      +/-   ##
=========================================
+ Coverage    19.66%    20%   +0.33%     
=========================================
  Files          111    111              
  Lines         2537   2530       -7     
=========================================
+ Hits           499    506       +7     
+ Misses        2038   2024      -14
Impacted Files Coverage Δ
.../commands/dao_cmds/token_cmds/change-controller.js 0% <0%> (ø) ⬆️
packages/aragon-cli/src/lib/token.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956208e...5859052. Read the comment docs.

Copy link
Contributor

@eternauta1337 eternauta1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xGabi 0xGabi merged commit e8a4fc6 into develop Dec 2, 2019
@0xGabi 0xGabi deleted the sdk7-token-change-controller branch December 2, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants