Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject web3 to deploy-apm script #453

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Inject web3 to deploy-apm script #453

merged 3 commits into from
Oct 30, 2018

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Oct 29, 2018

No description provided.

@bingen bingen self-assigned this Oct 29, 2018
@bingen bingen requested review from izqui and sohkai October 29, 2018 21:42
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.76% when pulling 85f9335 on inject_web3 into 2a008e4 on dev.

izqui
izqui approved these changes Oct 29, 2018
View reviewed changes
scripts/deploy-apm.js Outdated Show resolved Hide resolved
scripts/deploy-test-ens.js Outdated Show resolved Hide resolved
izqui and others added 2 commits October 30, 2018 10:19
@izqui @bingen
Fix web3 global in deploy-apm
56a609f 
Co-Authored-By: bingen <bingentxu@gmail.com>
@izqui @bingen
Fix web3 global in deploy-test-ens
750f247 
Co-Authored-By: bingen <bingentxu@gmail.com>
@bingen bingen merged commit 5378df8 into dev Oct 30, 2018
@sohkai sohkai deleted the inject_web3 branch November 19, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

@sohkai sohkai Awaiting requested review from sohkai

Assignees

@bingen bingen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingen @coveralls @izqui