Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split KitBase out of Bare into its own package #46

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Nov 8, 2018

No description provided.

@bingen bingen self-assigned this Nov 8, 2018
@bingen bingen requested review from izqui and sohkai November 8, 2018 11:40
Restore base dependency for Multisig and Democracy.
Copy link
Contributor

@izqui izqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested if the bare kit can be published? I think it needs an import from kits-base

@bingen
Copy link
Contributor Author

bingen commented Nov 8, 2018

Oh, good catch. I ran tests for the ones that have them and did "greps" searching for "kits-bare", but missed this obvious one, :-o. Fixing it now.

@bingen bingen merged commit 5cfe8e8 into master Nov 9, 2018
@sohkai sohkai deleted the split_KitBase branch November 9, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants