Skip to content

Bug fix/traversal collection detection fix #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 15, 2020

Conversation

hkernbach
Copy link
Member

Pull Request Guidelines

Scope & Purpose

An internal map was not filled with edge collections, where they should be. It was forgotten that edges can also point to a different edge and not only vertices.

Devel and 3.6.0 needs to be fixed.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (3.6.0)

Testing & Verification

This PR adds tests that were used to verify all changes:

  • Added new integration tests (/tests/js/server/aql/aql-graph-traverser.js)

@hkernbach hkernbach added this to the devel milestone Jan 8, 2020
@hkernbach hkernbach requested a review from mchacki January 8, 2020 11:06
@hkernbach
Copy link
Member Author

@hkernbach
Copy link
Member Author

Unrelated Jenkins failure.

@KVS85
Copy link
Contributor

KVS85 commented Jan 9, 2020

@KVS85
Copy link
Contributor

KVS85 commented Jan 9, 2020

@KVS85
Copy link
Contributor

KVS85 commented Jan 9, 2020

Tests blue.

Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ok.
I would like to see another test

@hkernbach
Copy link
Member Author

Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically OK, CHANGELOG missing

@hkernbach
Copy link
Member Author

Sorry, added.

@hkernbach
Copy link
Member Author

Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkernbach
Copy link
Member Author

@hkernbach
Copy link
Member Author

@KVS85 KVS85 merged commit 847175e into devel Jan 15, 2020
@KVS85 KVS85 deleted the bug-fix/traversal-collection-detection-fix branch January 15, 2020 19:34
ObiWahn added a commit that referenced this pull request Jan 16, 2020
…-fix/speedup-aql-datetime-parsing-pegtl

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/windows exe product info (#10869)
  Bug fix/traversal collection detection fix (#10801)
  fix compilation error
  Bug fix/issue 10852 (#10865)
  Update CHANGELOG
  apply documentation fix from @Simran-B
ObiWahn added a commit that referenced this pull request Jan 16, 2020
…ture/mimalloc

* 'devel' of https://github.com/arangodb/arangodb: (636 commits)
  Bug fix/windows exe product info (#10869)
  Bug fix/traversal collection detection fix (#10801)
  fix compilation error
  Bug fix/issue 10852 (#10865)
  Update CHANGELOG
  apply documentation fix from @Simran-B
  Update CHANGELOG
  remove remainders of allowDirectExecution (#10872)
  naively implement timeout for waitpid (#9943)
  Fix string comparison for AstNodes (#10837)
  Mention Web UI and command-line client tools in README.md (#10790)
  Bug fix/fixing multiple minor ui issues (#10700)
  Feature/http nextgen refactor (#10851)
  upgrade velocypack library (#10758)
  Remove uses of static ApplicationServer (#10806)
  speed up datetime parsing in AQL (#10846)
  make the logging a bit more efficient (#10849)
  switch log-file location depending on all/user installation, remove on uninstallation (#10832)
  changed roundCosts to removeCosts (#10638)
  fixed issue 10725 (#10750)
  ...
ObiWahn added a commit that referenced this pull request Jan 17, 2020
…ture/insert-or-update

* 'devel' of https://github.com/arangodb/arangodb: (27 commits)
  fix edge case with padding in VelocyPack arrays (#10901)
  Bug fix/windows exe product info (#10869)
  Bug fix/traversal collection detection fix (#10801)
  fix compilation error
  Bug fix/issue 10852 (#10865)
  Update CHANGELOG
  apply documentation fix from @Simran-B
  Update CHANGELOG
  remove remainders of allowDirectExecution (#10872)
  naively implement timeout for waitpid (#9943)
  Fix string comparison for AstNodes (#10837)
  Mention Web UI and command-line client tools in README.md (#10790)
  Bug fix/fixing multiple minor ui issues (#10700)
  Feature/http nextgen refactor (#10851)
  upgrade velocypack library (#10758)
  Remove uses of static ApplicationServer (#10806)
  speed up datetime parsing in AQL (#10846)
  make the logging a bit more efficient (#10849)
  switch log-file location depending on all/user installation, remove on uninstallation (#10832)
  changed roundCosts to removeCosts (#10638)
  ...
ObiWahn added a commit that referenced this pull request Jan 17, 2020
…ture/insert-or-update

* 'devel' of https://github.com/arangodb/arangodb: (27 commits)
  fix edge case with padding in VelocyPack arrays (#10901)
  Bug fix/windows exe product info (#10869)
  Bug fix/traversal collection detection fix (#10801)
  fix compilation error
  Bug fix/issue 10852 (#10865)
  Update CHANGELOG
  apply documentation fix from @Simran-B
  Update CHANGELOG
  remove remainders of allowDirectExecution (#10872)
  naively implement timeout for waitpid (#9943)
  Fix string comparison for AstNodes (#10837)
  Mention Web UI and command-line client tools in README.md (#10790)
  Bug fix/fixing multiple minor ui issues (#10700)
  Feature/http nextgen refactor (#10851)
  upgrade velocypack library (#10758)
  Remove uses of static ApplicationServer (#10806)
  speed up datetime parsing in AQL (#10846)
  make the logging a bit more efficient (#10849)
  switch log-file location depending on all/user installation, remove on uninstallation (#10832)
  changed roundCosts to removeCosts (#10638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants