ES-2678: Added checks to verify that clusterInfo() is (#21972) #21973
Conversation
* ES-2678: Added checks to verify that clusterInfo() is availble before accessing it. * Fixed linter errors * Fixed error reported by Cursor Bugbot * Added Changelog entry
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| // log crash dump feature | ||
| CrashHandler::logBacktrace(); | ||
| } | ||
| THROW_ARANGO_EXCEPTION(TRI_ERROR_SHUTTING_DOWN); |
There was a problem hiding this comment.
Bug: Cluster Info Null Error Masked
The clusterInfo() method now unconditionally throws TRI_ERROR_SHUTTING_DOWN when _clusterInfo is null. This is problematic because if the server is not shutting down, it previously triggered a fatal assertion. The new behavior replaces this critical error with a misleading TRI_ERROR_SHUTTING_DOWN exception, obscuring the actual problem of _clusterInfo being unavailable during normal operation.
There was a problem hiding this comment.
This is OK, because we maintain complete backwards compatibilitiy.
| // log crash dump feature | ||
| CrashHandler::logBacktrace(); | ||
| } | ||
| THROW_ARANGO_EXCEPTION(TRI_ERROR_SHUTTING_DOWN); |
There was a problem hiding this comment.
This is OK, because we maintain complete backwards compatibilitiy.
ES-2678: Added checks to verify that clusterInfo() is availble before accessing it.
Fixed linter errors
Fixed error reported by Cursor Bugbot
Added Changelog entry
Scope & Purpose
(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)