Skip to content

Implemented MinReplicationFactor. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Implemented MinReplicationFactor. #196

merged 1 commit into from
Jul 23, 2019

Conversation

maierlars
Copy link

No description provided.

@maierlars maierlars requested a review from neunhoef July 22, 2019 12:21
@maierlars maierlars self-assigned this Jul 22, 2019
neunhoef
neunhoef approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question: Isn't the default in go for an int field 0? What happens, if the go-driver user does not specify minReplicationFactor, then it will be 0. Is this handled correctly? I did not see the code for this.

@neunhoef neunhoef merged commit b7ccc51 into master Jul 23, 2019
@neunhoef neunhoef deleted the feature/minreplfact branch July 23, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@maierlars maierlars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maierlars @neunhoef