Skip to content

[Feature] Optional ResignLeadership #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

[Feature] Optional ResignLeadership #1246

merged 3 commits into from
Feb 21, 2023

Conversation

ajanikow
Copy link
Collaborator

After: #1245

@cla-bot cla-bot bot added the cla-signed label Feb 20, 2023
@ajanikow ajanikow changed the base branch from master to feature/optional_action February 20, 2023 02:34
@ajanikow ajanikow force-pushed the feature/resign_leadership_optional branch from 94bf968 to 9e4de1d Compare February 20, 2023 02:35
@ajanikow ajanikow force-pushed the feature/optional_action branch 2 times, most recently from 499bc4f to 19fc05d Compare February 20, 2023 04:42
Base automatically changed from feature/optional_action to master February 20, 2023 11:20
@ajanikow ajanikow force-pushed the feature/resign_leadership_optional branch from 9e4de1d to 740d1b7 Compare February 20, 2023 11:22
informalict
informalict reviewed Feb 21, 2023
View reviewed changes
informalict
informalict approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with small suggestion

@ajanikow ajanikow merged commit e709c07 into master Feb 21, 2023
@ajanikow ajanikow deleted the feature/resign_leadership_optional branch February 21, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@informalict informalict informalict approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajanikow @informalict