Skip to content

GT-402 Fix for ArangoTask list error #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2023
Merged

GT-402 Fix for ArangoTask list error #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb4e8b4
GT-402 Fix for ArangoTask list error
jwierzbo Apr 12, 2023
71b2284
revert
jwierzbo Apr 13, 2023
4848a3f
review fix
jwierzbo Apr 14, 2023
2b6f43f
review fix
jwierzbo Apr 14, 2023
ee540d9
review fix
jwierzbo Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [master](https://github.com/arangodb/kube-arangodb/tree/master) (N/A)
- (Bugfix) Fix manual overwrite for ReplicasCount in helm
- (Bugfix) Fix for ArangoTask list error

## [1.2.25](https://github.com/arangodb/kube-arangodb/tree/1.2.25) (2023-04-07)
- (Feature) Add Generics & Drop policy/v1beta1 support
Expand Down
3 changes: 0 additions & 3 deletions chart/kube-arangodb/crds/database-task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ spec:
kind: ArangoTask
listKind: ArangoTaskList
plural: arangotasks
shortNames:
- arangodb
- arango
singular: arangotask
scope: Namespaced
versions:
Expand Down
3 changes: 0 additions & 3 deletions pkg/crd/crds/database-task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ spec:
kind: ArangoTask
listKind: ArangoTaskList
plural: arangotasks
shortNames:
- arangodb
- arango
singular: arangotask
scope: Namespaced
versions:
Expand Down
4 changes: 2 additions & 2 deletions pkg/deployment/resources/inspector/inspector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ func (i *inspectorState) RegisterInformers(k8s informers.SharedInformerFactory,
// Arango
arango.Database().V1().ArangoMembers().Informer().AddEventHandler(i.eventHandler(definitions.ArangoMember))

if _, err := i.ArangoTask().V1(); err != nil {
if _, err := i.ArangoTask().V1(); err == nil {
arango.Database().V1().ArangoTasks().Informer().AddEventHandler(i.eventHandler(definitions.ArangoTask))
}

if _, err := i.ArangoClusterSynchronization().V1(); err != nil {
if _, err := i.ArangoClusterSynchronization().V1(); err == nil {
arango.Database().V1().ArangoClusterSynchronizations().Informer().AddEventHandler(i.eventHandler(definitions.ArangoClusterSynchronization))
}
}
Expand Down