Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compare Generic #1480

Merged
merged 3 commits into from
Nov 13, 2023
Merged

[Feature] Compare Generic #1480

merged 3 commits into from
Nov 13, 2023

Conversation

ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Nov 8, 2023

No description provided.

@ajanikow ajanikow requested a review from a team as a code owner November 8, 2023 18:19
@cla-bot cla-bot bot added the cla-signed label Nov 8, 2023
Copy link
Contributor

@nikita-vanyasin nikita-vanyasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see suggestions

pkg/util/compare/compare.go Show resolved Hide resolved
pkg/util/compare/compare.go Outdated Show resolved Hide resolved
pkg/util/compare/mode.go Show resolved Hide resolved
@ajanikow ajanikow merged commit 934039f into master Nov 13, 2023
3 checks passed
@ajanikow ajanikow deleted the feature/compare_generic branch November 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants