[Feature] Parametrize Scheduling Graceful Duration #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanikow
force-pushed
the
feature/parametrize_scheduling_graceful_duration
branch
from
85fa8ec
to
27e2c9d
Compare
ajanikow
force-pushed
the
feature/parametrize_scheduling_graceful_duration
branch
from
27e2c9d
to
5cc2206
Compare
jwierzbo
approved these changes
Apr 8, 2024
jwierzbo
reviewed
Apr 8, 2024
| @@ -29,6 +29,7 @@ const ( | |||
| DefaultArangoDCheckTimeout = time.Second * 2 | |||
| DefaultReconciliationTimeout = time.Minute | |||
| DefaultForcePodDeletionGracePeriodTimeout = 15 * time.Minute | |||
| DefaultPodSchedulingGracePeriod = 15 * time.Second | |||
There was a problem hiding this comment.
IMO it could be bit longer (60s)
There was a problem hiding this comment.
Before it was 0 seconds, now it will 15 (what is enough for AS to take an action - where default is set to 10s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.