-
Notifications
You must be signed in to change notification settings - Fork 73
[Feature] [Platform] Enable HTTP to HTTPS Redirect #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f76750
to
5960465
Compare
0b8a39c
to
44c01af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements HTTP to HTTPS redirect functionality for the gateway platform. The change automatically redirects HTTP traffic to HTTPS when TLS is configured, improving security by ensuring encrypted connections.
- Adds new
HttpToHttpsChain()
method to generate Envoy filter chain for HTTP to HTTPS redirection - Updates SNI configuration to explicitly specify TLS transport protocol for proper traffic matching
- Refactors secondary filter chain rendering to accommodate both redirect and SNI configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
pkg/deployment/resources/gateway/gateway_config.go | Implements HTTP to HTTPS redirect logic with new filter chain generation |
pkg/deployment/resources/gateway/gateway_config_sni.go | Adds explicit TLS transport protocol specification for SNI matching |
CHANGELOG.md | Documents the new HTTP to HTTPS redirect feature |
Comments suppressed due to low confidence (3)
pkg/deployment/resources/gateway/gateway_config.go:430
- [nitpick] The StatPrefix "ingress_http" should be more descriptive to indicate this is specifically for HTTP to HTTPS redirect functionality, such as "http_to_https_redirect".
StatPrefix: "ingress_http",
pkg/deployment/resources/gateway/gateway_config.go:434
- [nitpick] The route configuration name "local_http" should be more descriptive to indicate this handles HTTP to HTTPS redirects, such as "http_to_https_redirect_route".
Name: "local_http",
pkg/deployment/resources/gateway/gateway_config.go:437
- [nitpick] The virtual host name "local_http" should be more descriptive to indicate this handles HTTP to HTTPS redirects, such as "http_to_https_redirect_host".
Name: "local_http",
No description provided.