Skip to content

Conversation

ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2025
@ajanikow ajanikow requested a review from Copilot July 22, 2025 11:55
Copilot

This comment was marked as outdated.

@ajanikow ajanikow requested a review from Copilot July 22, 2025 12:13
Copilot

This comment was marked as outdated.

@ajanikow ajanikow force-pushed the feature/platform/http_to_https branch from 3f76750 to 5960465 Compare July 22, 2025 13:36
@ajanikow ajanikow force-pushed the feature/platform/http_to_https branch from 0b8a39c to 44c01af Compare July 22, 2025 15:21
@ajanikow ajanikow requested a review from Copilot July 22, 2025 15:27
Copilot

This comment was marked as outdated.

@ajanikow ajanikow requested a review from Copilot July 22, 2025 17:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements HTTP to HTTPS redirect functionality for the gateway platform. The change automatically redirects HTTP traffic to HTTPS when TLS is configured, improving security by ensuring encrypted connections.

  • Adds new HttpToHttpsChain() method to generate Envoy filter chain for HTTP to HTTPS redirection
  • Updates SNI configuration to explicitly specify TLS transport protocol for proper traffic matching
  • Refactors secondary filter chain rendering to accommodate both redirect and SNI configurations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/deployment/resources/gateway/gateway_config.go Implements HTTP to HTTPS redirect logic with new filter chain generation
pkg/deployment/resources/gateway/gateway_config_sni.go Adds explicit TLS transport protocol specification for SNI matching
CHANGELOG.md Documents the new HTTP to HTTPS redirect feature
Comments suppressed due to low confidence (3)

pkg/deployment/resources/gateway/gateway_config.go:430

  • [nitpick] The StatPrefix "ingress_http" should be more descriptive to indicate this is specifically for HTTP to HTTPS redirect functionality, such as "http_to_https_redirect".
		StatPrefix: "ingress_http",

pkg/deployment/resources/gateway/gateway_config.go:434

  • [nitpick] The route configuration name "local_http" should be more descriptive to indicate this handles HTTP to HTTPS redirects, such as "http_to_https_redirect_route".
				Name: "local_http",

pkg/deployment/resources/gateway/gateway_config.go:437

  • [nitpick] The virtual host name "local_http" should be more descriptive to indicate this handles HTTP to HTTPS redirects, such as "http_to_https_redirect_host".
						Name:    "local_http",

@ajanikow ajanikow merged commit e91ff10 into master Jul 23, 2025
3 checks passed
@ajanikow ajanikow deleted the feature/platform/http_to_https branch July 23, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants