[Feature] Helm Lint #1953
[Feature] Helm Lint #1953
Conversation
ajanikow
requested review from
Copilot and
jwierzbo
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Helm lint compliance issues by reformatting inline YAML arrays to multi-line format for better readability and lint conformance. The changes standardize RBAC role definitions and webhook configurations across all Helm charts.
- Converts inline array notation (
["value"]) to multi-line YAML list format - Updates webhook admission review versions and rule configurations
- Expands wildcard permissions (
["*"]) to explicit verb lists for better security practices
Reviewed Changes
Copilot reviewed 109 out of 237 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webhook/mutation.yaml (all charts) | Converts inline arrays for apiGroups, apiVersions, operations, resources, and admissionReviewVersions to multi-line format |
| role.yaml files (all operators) | Expands wildcard verb permissions to explicit lists and converts inline arrays to multi-line format |
| cluster-role.yaml files (all operators) | Standardizes apiGroups, resources, and verbs arrays to multi-line format |
| CHANGELOG.md | Documents the Helm Lint feature addition |
Comments suppressed due to low confidence (9)
| - "database.arangodb.com" | ||
| resources: | ||
| - "arangodeployments" | ||
| - "arangodeployments/status","arangomembers", "arangomembers/status" |
There was a problem hiding this comment.
The resources array contains improperly formatted comma-separated values. Each resource should be on its own line with proper YAML list formatting.
| - "arangodeployments/status","arangomembers", "arangomembers/status" | |
| - "arangodeployments/status" | |
| - "arangomembers" | |
| - "arangomembers/status" |
Copilot uses AI. Check for mistakes.
| - "backup.arangodb.com" | ||
| resources: | ||
| - "arangobackuppolicies" | ||
| - "arangobackuppolicies/status", "arangobackups", "arangobackups/status" |
There was a problem hiding this comment.
The resources array contains improperly formatted comma-separated values. Each resource should be on its own line with proper YAML list formatting.
| - "arangobackuppolicies/status", "arangobackups", "arangobackups/status" | |
| - "arangobackuppolicies/status" | |
| - "arangobackups" | |
| - "arangobackups/status" |
Copilot uses AI. Check for mistakes.
| - apiGroups: | ||
| - "apps.arangodb.com" | ||
| resources: | ||
| - "arangojobs","arangojobs/status" |
There was a problem hiding this comment.
The resources array contains improperly formatted comma-separated values. Each resource should be on its own line with proper YAML list formatting.
| - "arangojobs","arangojobs/status" | |
| - "arangojobs" | |
| - "arangojobs/status" |
Copilot uses AI. Check for mistakes.
2 participants
No description provided.