GA-148 | DiGraph Support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkernbach
reviewed
Aug 5, 2024
| @@ -405,6 +420,154 @@ def test_graph_edges_crud(load_graph: Any) -> None: | |||
| assert db.document(edge_id)["object"]["sub_object"]["foo"] == "baz" | |||
|
|
|||
|
|
|||
| def test_digraph_edges_crud(load_graph: Any) -> None: | |||
There was a problem hiding this comment.
Somewhen later when we introduce more graph types we should generalize common tests - and only test edge-cases/corner-cases for specific graph types.
1.) Common tests which are globally valid for all graphs
2.) Then per-graph-type tests, like e.g. multiple edges between same nodes for MultiGraph etc.
There was a problem hiding this comment.
completely makes sense. separate PR to restructure the tests in general will be good to do
hkernbach
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.