Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE-558] ArangoSearch column cache #258

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

apetenchea
Copy link
Member

A couple of inverted index parameters were introduced in 3.10.2 (enterprise only):

  • cache: Always cache the field normalization values in memory for all fields by default.
  • primaryKeyCache: Always cache the primary key column in memory.

This PR adds them as parameters to Collection.add_inverted_index and adds a relevant unit test for inverted index creation.
Additionally, a views test has been enhanced.

@codecov-commenter
Copy link

Codecov Report

Merging #258 (7a9df25) into main (8b09e07) will increase coverage by 0.43%.
The diff coverage is 86.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   98.58%   99.02%   +0.43%     
==========================================
  Files          26       26              
  Lines        3899     3912      +13     
==========================================
+ Hits         3844     3874      +30     
+ Misses         55       38      -17     
Impacted Files Coverage Δ
arango/collection.py 98.48% <50.00%> (+2.00%) ⬆️
arango/aql.py 95.04% <100.00%> (+0.04%) ⬆️
arango/cursor.py 100.00% <100.00%> (ø)

@CryptoNinjaGeek CryptoNinjaGeek merged commit 4bb8c6c into main Jul 14, 2023
6 checks passed
@CryptoNinjaGeek CryptoNinjaGeek deleted the feature/de-558-arangosearch-column-cache branch July 14, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants