Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE-562] Index Cache Refilling #259

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

apetenchea
Copy link
Member

Adding new per-operation option refillIndexCache to write operations:

  • single-document write operations (insert, replace, update, delete)
  • multi-document write operations (insert_many, replace_many, update_many, delete_many)

If the option is set to True, new entries are added to in-memory index caches if
document operations affect the edge index or cache-enabled persistent indexes. Every
currently running transaction will keep track of which in-memory index cache entries
were invalidated by the transaction, and will try to (re-)fill them later.

Example:

collection.insert({"foo": "bar"}, refillIndexCaches=True)
db.aql.execute("INSERT {foo: bar} INTO collection OPTIONS { refillIndexCaches: true }")

Copy link

@dothebart dothebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention Arangodb along with these version number comments, else LGTM.

@aMahanna aMahanna requested a review from dothebart July 24, 2023 16:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #259 (7c2bc15) into main (8b09e07) will increase coverage by 0.42%.
The diff coverage is 95.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   98.58%   99.01%   +0.42%     
==========================================
  Files          26       26              
  Lines        3899     3947      +48     
==========================================
+ Hits         3844     3908      +64     
+ Misses         55       39      -16     
Impacted Files Coverage Δ
arango/client.py 98.30% <75.00%> (-1.70%) ⬇️
arango/collection.py 98.50% <90.00%> (+2.03%) ⬆️
arango/aql.py 95.04% <100.00%> (+0.04%) ⬆️
arango/cursor.py 100.00% <100.00%> (ø)
arango/http.py 100.00% <100.00%> (ø)

@aMahanna
Copy link
Member

I would mention Arangodb along with these version number comments, else LGTM.

updated as of 7c2bc15

feel free to merge

@aMahanna aMahanna merged commit 5fdf941 into main Jul 24, 2023
6 checks passed
@aMahanna aMahanna deleted the feature/de-562-index-cache-refilling branch July 24, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants