Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection test #341

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix collection test #341

merged 1 commit into from Apr 26, 2024

Conversation

apetenchea
Copy link
Member

@apetenchea apetenchea commented Apr 25, 2024

test_collection.py::test_collection_management now fails due to arango.exceptions.CollectionCreateError: [HTTP 400][ERR 10] Value cannot be empty. on attribute distributeShardsLike. This happens because the shard_like parameter is empty. Truth be told, that was never a valid configuration, but since 3.12 the validation got better and now we're actually throwing an exception.

This PR removes the empty value and adds proper testing for the shard_like parameter.

With that, all cluster tests should turn green.

@apetenchea apetenchea self-assigned this Apr 25, 2024
Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice good catch!

@apetenchea apetenchea merged commit eb77382 into main Apr 26, 2024
28 of 36 checks passed
@apetenchea apetenchea deleted the bug-fix/distribute-shards-like-test branch April 26, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants