Skip to content

Reorganize project while attempting to maintain as much backwards compatibility as possible #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions arango/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
from arango.client import ArangoClient # noqa: F401
from arango.exceptions import ArangoError # noqa: F401
from arango.utils.lock import RLock # noqa: F401
from .request import Request # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use relative import? Otherwise please change to arango.request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I stated in the post below, I only used relative import for the init.py files, but can change them if you'd like.

from arango.api.wal import WriteAheadLog # noqa: F401
from .client import ArangoClient # noqa: F401
11 changes: 0 additions & 11 deletions arango/api.py

This file was deleted.

1 change: 1 addition & 0 deletions arango/api/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from .api import APIWrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again please avoid relative import for consistency.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

18 changes: 18 additions & 0 deletions arango/api/api.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from abc import ABCMeta


class APIWrapper:
__metaclass__ = ABCMeta

def __init__(self, connection):
self._conn = connection

def handle_request(self, request, handler, job_class=None,
use_underlying=False, **kwargs):
if use_underlying:
connection = self._conn.underlying
else:
connection = self._conn

return connection.handle_request(request, handler, job_class=job_class,
**kwargs)
4 changes: 4 additions & 0 deletions arango/api/collections/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
from .base import BaseCollection
from .standard import Collection
from .edge import EdgeCollection # noqa: F401
from .vertex import VertexCollection
Loading