Skip to content

Conversation

SLasyaN
Copy link
Contributor

@SLasyaN SLasyaN commented May 28, 2025

ArangoGraph and ArangoGraphQAChain integration and unit tests

Note
commands used- make tests unit_tests, make integration_tests integration_tests
Coverage is 98% for ArangoGraph and 100% for ArangoGraphQAChain
Lint tests pending

Changes made

  • Made changes to FakeLLM class and ArangoGraph code as well
  • Added integration testsand unit tests

@SLasyaN SLasyaN changed the base branch from main to tests May 28, 2025 16:10
Base automatically changed from tests to main May 30, 2025 17:07
Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, minor comments left for approval:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

.DS_Store Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

aMahanna and others added 7 commits June 9, 2025 12:35
commit f5e7cc1
Author: Ajay Kallepalli <72517322+ajaykallepalli@users.noreply.github.com>
Date:   Mon Jun 9 07:39:38 2025 -0700

    Coverage for Hybrid search added (#8)

    * Coverage for Hybrid search added

    * Fix lint

commit a25e871
Merge: 8d3cbd4 d00bd64
Author: Ajay Kallepalli <72517322+ajaykallepalli@users.noreply.github.com>
Date:   Mon Jun 2 09:19:58 2025 -0700

    Merge pull request #3 from arangoml/chat_vector_tests

    unit and integration tests for chat message histories and vector stores

commit 8d3cbd4
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 13:30:22 2025 -0400

    bump: version

commit cae31bf
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 13:30:17 2025 -0400

    fix: _release

commit 7d85751
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 13:11:10 2025 -0400

    bump: version

commit d00bd64
Merge: 70e6cfd 994b540
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 13:07:54 2025 -0400

    Merge branch 'main' into chat_vector_tests

commit 70e6cfd
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 13:04:37 2025 -0400

    fix: ci

commit b7b53f2
Merge: 24a28ac 61950e2
Author: Anthony Mahanna <anthony.mahanna@arangodb.com>
Date:   Fri May 30 11:58:54 2025 -0400

    Merge branch 'tests' into chat_vector_tests

commit 24a28ac
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 28 08:07:17 2025 -0700

    ruff format locally failing CI/CD

commit 65aace7
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 28 07:55:39 2025 -0700

    Updating assert statements

commit 5906fbf
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 28 07:51:53 2025 -0700

    Updating assert statements

commit 9e0031a
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 10:18:05 2025 -0700

    make format py312

commit 8ceac2d
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 09:58:41 2025 -0700

    Updating assert statements to match latest ruff requirements python 12

commit bbbcecc
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 09:45:32 2025 -0700

    Updating assert statements to match latest ruff requirements

commit cde5615
Merge: 5034e4a 9344bf6
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 09:36:41 2025 -0700

    Merge branch 'tests' into chat_vector_tests

commit 5034e4a
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 08:38:23 2025 -0700

    No lint errors, all tests pass

commit 9c35b8f
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 21 08:37:40 2025 -0700

    No lint errors

commit ccad356
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Sun May 18 20:21:57 2025 -0700

    Fixing linting and formatting errors

commit 581808f
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Sun May 18 20:01:12 2025 -0700

    Testing from existing collection, all major coverage complete

commit 4025fb7
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Sun May 18 18:23:29 2025 -0700

    Adding unit tests and integration tests for get by id

commit 895a97a
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Sun May 18 17:43:07 2025 -0700

    All integration test and unit test passing, coverage 73% and 66%

commit 5679003
Merge: b95bb04 b361cd2
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 14 10:50:48 2025 -0700

    Merge branch 'tests' into chat_vector_tests

commit b95bb04
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 14 09:03:20 2025 -0700

    No changes to arangodb_vector

commit 11a08fe
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 14 08:41:58 2025 -0700

    minimal changes to arangodb_vector.py

commit 4560c9c
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 14 08:12:52 2025 -0700

    All 18 tests pass

commit 463ea08
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 7 08:45:41 2025 -0700

    Adding chat history unit tests

commit f7fa9d9
Author: Ajay Kallepalli <ajay.r.kallepalli@gmail.com>
Date:   Wed May 7 07:47:37 2025 -0700

    integration_tests_chat_history all passing
@aMahanna aMahanna merged commit 681cbb0 into main Jun 9, 2025
8 checks passed
@aMahanna aMahanna deleted the test_lasya branch June 9, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants