Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allen tutorial #1781

Merged
merged 14 commits into from
Jun 8, 2022
Merged

Allen tutorial #1781

merged 14 commits into from
Jun 8, 2022

Conversation

brenthuisman
Copy link
Contributor

@thorstenhater thorstenhater marked this pull request as ready for review March 16, 2022 09:18
thorstenhater
thorstenhater requested changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments. A general observation after seeing more of these examples:
Next release planning should be focussing on ergonomics.

python/example/single_cell_allen.py Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
@brenthuisman brenthuisman marked this pull request as draft March 17, 2022 12:09
@brenthuisman brenthuisman marked this pull request as ready for review March 18, 2022 10:07
thorstenhater
thorstenhater requested changes May 5, 2022
View reviewed changes
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
thorstenhater
thorstenhater requested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks left, then good to merge.

doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
doc/tutorial/single_cell_allen.rst Outdated Show resolved Hide resolved
python/example/single_cell_allen.py Show resolved Hide resolved
python/example/single_cell_allen.py Outdated Show resolved Hide resolved
@thorstenhater thorstenhater merged commit e92342d into arbor-sim:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthuisman @thorstenhater