support rk3588 smp #121
Merged
support rk3588 smp #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhenxihuan
force-pushed
the
master
branch
2 times, most recently
from
f62070c to
c7724fa
Compare
aarkegz
reviewed
Apr 18, 2025
If x86 and riscv also need to be refreshed, then such an interface is indeed needed. |
Closed
arceos主线曾提起过cache相关功能，但未合并，且没给出未合并原因，与这个PR功能重复 arceos-org/arceos#210 @aarkegz |
Closed
aarkegz
requested changes
May 15, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enables support for RK3588 SMP on aarch64 by revising how virtual CPUs are activated and integrating new cache management functions along with updated configuration and build scripts.
- Update vCPU activation logic to map physical CPU IDs to vCPU IDs from the configuration
- Introduce a new cache module (with assembly routines) and integrate cache cleaning in image loading
- Update Makefile and platform configuration files to support GICv3 and RK3588-specific naming
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vmm/vcpus.rs | Adjusts vCPU activation to use configuration mapping instead of direct physical IDs |
| src/vmm/mod.rs | Conditionally includes the new cache module for aarch64 |
| src/vmm/images.rs | Invokes cache cleaning for memory regions on aarch64 |
| src/vmm/cache.rs & src/vmm/cache.S | Introduces new cache management routines via assembly |
| scripts/make/qemu.mk, features.mk, Makefile | Updates build scripts for GICv3 support and RK3588 platform identification |
| configs/*.toml | Updates configuration files for the RK3588 SMP and related platforms |
Comments suppressed due to low confidence (2)
src/vmm/vcpus.rs:298
- Consider enhancing the error message with additional context or instructions to help diagnose misconfiguration issues if the physical CPU ID is missing from the mapping.
.expect(&format!("Physical CPU ID {} not found in VM configuration", target_cpu));
Makefile:158
- [nitpick] Ensure that the platform name 'aarch64-rk3588j-hv' is consistently used across all related configuration and documentation files to avoid confusion.
else ifeq ($(PLAT_NAME), aarch64-rk3588j-hv)
…e vCPU startup logic - Add phys_cpu_ids configuration item in linux-rk3588-aarch64-smp.toml - Modify vcpu_run function to start corresponding vCPU according to configured physical CPU ID mapping - Optimize vCPU startup logic to improve system startup efficiency and stability
* move cache invalidators into `utils::arch` mod * formatted * fixed missing `pub` vis * fix two missing commas in `qemu.mk`, which caused `make ARCH=aarch64 run` failed to start
aarkegz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the feature of dtb parsing has not yet been merged into the mainline, the address in the toml configuration is still used to refresh the dcache