feat: clippy warning as error, log to english #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables Clippy warnings to be treated as errors and refactors module visibility to fix related warnings. The primary goal is to enforce stricter code quality by making Clippy warnings cause build failures.
- Configures Clippy to treat warnings as errors via the
-D warningsflag - Refactors the
fsmodule from private to public to fix module visibility issues - Updates import paths and dead code annotations to align with the new module structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/clippy.py | Adds -D warnings flag to make Clippy warnings fail builds |
| src/vmm/images/mod.rs | Changes fs module to public and removes re-export pattern |
| src/vmm/fdt/mod.rs | Updates import path to use the now-public fs module directly |
| src/vmm/config.rs | Consolidates dead code allowances at module level |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…stency - Translated comments and output messages in axvisor.sh to English for better accessibility. - Enhanced error handling and output messages in bootstrap.sh, build.py, clean.py, clippy.py, disk_img.py, run.py, and setup.py. - Updated requirements.txt to reflect English comments. - Improved structure and readability of code across various scripts. - Ensured consistent terminology and formatting in all output messages.
ZR233
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.