Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previous public key pending validation #1441

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 27, 2024

Description

Fixes an issue where a user could create a transaction with the previous public key as the next public, breaking the chain as the previous transaction address is the current transaction address

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining labels Feb 27, 2024
@Neylix Neylix merged commit d1aa680 into archethic-foundation:release/1.4.8-rc3 Feb 27, 2024
1 of 2 checks passed
@Neylix Neylix deleted the Add-previous-pub-control branch February 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant