Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mining timeout #1483

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Mar 27, 2024

Description

Improve mining timeout with a reference timeout. As it all the nodes will have the timeout at the same time.
Also placed prior validation after building context
Also updated the mining timeout with new values based on new smart contract validation

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Started 3 nodes, launched some benchmark, it worked well.
Stopped one and did some faucet, it worked well after coordinator or context timeout

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added mining Involve transaction validation and mining enhancements labels Mar 27, 2024
@Neylix Neylix added this to the 1.5.1 milestone Mar 29, 2024
@Neylix Neylix merged commit 95c36e0 into archethic-foundation:develop Apr 17, 2024
1 check failed
@Neylix Neylix deleted the Improve-mining-timeout branch April 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants