-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap: Replicate missed transaction of current summary #1494
Merged
Neylix
merged 13 commits into
archethic-foundation:develop
from
bchamagne:1468-selfrepair-current-summary
May 6, 2024
Merged
Bootstrap: Replicate missed transaction of current summary #1494
Neylix
merged 13 commits into
archethic-foundation:develop
from
bchamagne:1468-selfrepair-current-summary
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchamagne
force-pushed
the
1468-selfrepair-current-summary
branch
from
April 8, 2024 14:41
4241d24
to
1ebc3e6
Compare
Neylix
requested changes
Apr 18, 2024
lib/archethic/p2p/message/get_current_replications_attestations.ex
Outdated
Show resolved
Hide resolved
Neylix
requested changes
Apr 22, 2024
lib/archethic/p2p/message/get_current_replications_attestations.ex
Outdated
Show resolved
Hide resolved
bchamagne
force-pushed
the
1468-selfrepair-current-summary
branch
from
April 25, 2024 07:58
aa5f57a
to
d338f33
Compare
2 tasks
Neylix
requested changes
May 3, 2024
replication_attestations: | ||
subsets | ||
|> Stream.flat_map(&BeaconChain.get_current_summary_replication_attestations/1) | ||
|> ReplicationAttestation.reduce_confirmations() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the reducing confirmations is already done in the BeaconChain function, it is not needed to do it here as it isn't possible to have attestation for the same transaction on different subset
Neylix
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a node starts and is authorized, it'll catch up the missed transaction of current summary (current day)
Fixes #1468
Type of change
How Has This Been Tested?
Unit tested
Manual test of this scenario:
Checklist: