Metrics: add P2P.nodes_connected #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neylix
reviewed
May 22, 2024
bchamagne
force-pushed
the
metrics-nodes-connected
branch
from
6707d42
to
3745b73
Compare
samuelmanzanera
approved these changes
Jun 10, 2024
samuelmanzanera
merged commit 31f8741
into
archethic-foundation:develop
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a metric to count the number of nodes currently connected.
This will be useful to detect splits or nodes that are not connected to anyone but still accept incoming connections (so they appear available, but in the end they cannot request anything outside of its shard resulting in wrong replies)