Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beacon live transaction chain loading #360

Merged
2 commits merged into from
Jun 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2022

Description

Fix the transaction loading issue in the beacon chain from the first page.

It targets the transaction chain of the current day to retrieve the beacon slots transaction and aggregate them.

Related to #291

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

When a transaction is submitted and stored on the beacon chain, when the next slot is sealed and send through a transaction, when you are refreshing the first page, you should be able to see the transaction and the previous ones.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch from 21b51b7 to 6beba0c Compare June 2, 2022 14:25
@ghost
Copy link
Author

ghost commented Jun 2, 2022

@ghost ghost added UI Invole user interface beacon chain Involve BeaconChain labels Jun 2, 2022
@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch from 6beba0c to 1521b1b Compare June 2, 2022 15:02
@ghost ghost marked this pull request as ready for review June 2, 2022 15:03
@ghost ghost requested a review from imnik11 June 2, 2022 15:03
@ghost ghost self-assigned this Jun 2, 2022
@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch 2 times, most recently from d8d3ffd to 832dbec Compare June 2, 2022 15:20
@ghost ghost added the bug Something isn't working label Jun 2, 2022
@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch from 832dbec to f67c70b Compare June 3, 2022 06:20
@ghost ghost added the core team Assigned to the core team label Jun 3, 2022
@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch 2 times, most recently from f68f8a6 to 2d355ab Compare June 8, 2022 13:49
Copy link
Contributor

@imnik11 imnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM, live streaming is also being cached along with pagination.

@ghost ghost force-pushed the 06-02-Fix_beacon_live_transaction_chain_loading branch from 2d355ab to 823d51e Compare June 9, 2022 08:05
@ghost ghost merged commit 65a83ec into develop Jun 9, 2022
@ghost ghost deleted the 06-02-Fix_beacon_live_transaction_chain_loading branch June 9, 2022 08:17
@ghost ghost mentioned this pull request Jun 9, 2022
3 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working core team Assigned to the core team UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant