-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix beacon live transaction chain loading #360
Merged
Merged
+170
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
from
June 2, 2022 14:25
21b51b7
to
6beba0c
Compare
ghost
mentioned this pull request
Jun 2, 2022
This was referenced Jun 2, 2022
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
from
June 2, 2022 15:02
6beba0c
to
1521b1b
Compare
ghost
marked this pull request as ready for review
June 2, 2022 15:03
ghost
requested a review
from imnik11
June 2, 2022 15:03
ghost
self-assigned this
Jun 2, 2022
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
2 times, most recently
from
June 2, 2022 15:20
d8d3ffd
to
832dbec
Compare
imnik11
reviewed
Jun 2, 2022
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
from
June 3, 2022 06:20
832dbec
to
f67c70b
Compare
imnik11
approved these changes
Jun 5, 2022
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
2 times, most recently
from
June 8, 2022 13:49
f68f8a6
to
2d355ab
Compare
imnik11
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM, live streaming is also being cached along with pagination.
ghost
force-pushed
the
06-02-Fix_beacon_live_transaction_chain_loading
branch
from
June 9, 2022 08:05
2d355ab
to
823d51e
Compare
ghost
deleted the
06-02-Fix_beacon_live_transaction_chain_loading
branch
June 9, 2022 08:17
ghost
mentioned this pull request
Jun 9, 2022
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beacon chain
Involve BeaconChain
bug
Something isn't working
core team
Assigned to the core team
UI
Invole user interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the transaction loading issue in the beacon chain from the first page.
It targets the transaction chain of the current day to retrieve the beacon slots transaction and aggregate them.
Related to #291
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
When a transaction is submitted and stored on the beacon chain, when the next slot is sealed and send through a transaction, when you are refreshing the first page, you should be able to see the transaction and the previous ones.
Checklist: