Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs builder extensions #162 #163

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

vittorelli
Copy link
Contributor

Work in progress. Does this look okay?
Or should the docs contain less code and move that into the sample projects in stead?

Copy link
Owner

@ardalis ardalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - having code in the docs is good so folks don't need to hunt down the sample separately. You can link to the sample as needed if it's something where seeing it in context of a whole app will add clarity.

docs/extensions/create-specification-builder.md Outdated Show resolved Hide resolved
docs/extensions/create-specification-builder.md Outdated Show resolved Hide resolved
docs/extensions/create-specification-builder.md Outdated Show resolved Hide resolved
docs/extensions/create-specification-builder.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Smith <steve@kentsmiths.com>
@fiseni
Copy link
Collaborator

fiseni commented Sep 26, 2021

You're doing great work here @vittorelli.
While designing the infrastructure and the multi-level chain structure, never thought anyone will analyze it thoroughly or make use of it 😄 I'm glad that users are utilizing this extensibility.

@vittorelli
Copy link
Contributor Author

Looks great - having code in the docs is good so folks don't need to hunt down the sample separately. You can link to the sample as needed if it's something where seeing it in context of a whole app will add clarity.

Also, although the title is all about "How" it would be great to say "Why" one would want/need to do this somewhere at the top, too.

I've updated the docs so it answers to the "Why". I didn't add it as a sample in the source because I felt it would somewhat conflict with the existing CachedRepository sample.

@vittorelli
Copy link
Contributor Author

You're doing great work here @vittorelli.
While designing the infrastructure and the multi-level chain structure, never thought anyone will analyze it thoroughly or make use of it 😄 I'm glad that users are utilizing this extensibility.

@fiseni Thanks :-)
I'm happy to contribute. It helped me a lot on several projects!

@ardalis ardalis merged commit fa77be3 into ardalis:main Sep 27, 2021
@ardalis
Copy link
Owner

ardalis commented Sep 27, 2021

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants